-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
passing country as prop instead of countryCode as it is not unique #403
base: master
Are you sure you want to change the base?
Conversation
✔️ Deploy Preview for pensive-johnson-e2d194 ready! 🔨 Explore the source changes: 74506c0 🔍 Inspect the deploy log: https://app.netlify.com/sites/pensive-johnson-e2d194/deploys/61f6325779334700078a5de1 😎 Browse the preview: https://deploy-preview-403--pensive-johnson-e2d194.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #403 +/- ##
=======================================
Coverage 83.25% 83.25%
=======================================
Files 84 84
Lines 1362 1362
Branches 270 263 -7
=======================================
Hits 1134 1134
- Misses 193 194 +1
+ Partials 35 34 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change wont be backwards compatible and require massive rewrites in consumer code
without this change we are not able to identify UK numbers from Jersey. Also, we can't correctly validate UK numbers because Jersey gets selected. The original component is actually wrong in returning just the country code. |
country code is not a unique key that can be passed, so updating the component to pass country
Issue Usecase: UK vs Jersey
https://deploy-preview-403--pensive-johnson-e2d194.netlify.app/?path=/story/components-phonenumberinput--material